docs: add instructions for deleting orphaned scanning VMs #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirklandnuts
requested review from
goodmorninggoaway,
thekeys93 and
declanwilson-lw
wilderj
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If AWLS is deprovisioned while a scan is in progress, any existing scanning VMs will remain and cannot be deleted by terraform because they are dynamically created by sidekick. In this case,
terraform destroywill fail to delete a subnet it created (because the subnet is still in use by the orphaned scanning VMs) and error out.To resolve this, the scanning VMs must be deleted before re-running
terraform destroy. I've added a note in the README to explain this and guide users through the resolution. I also updated the scanning subscription permissions to allow the deployment service princpal to delete VMs as is required.How did you test this change?
I verified that running the command indeed deleted the scanning VMs, and successfully ran
terraform destroywhen it was previously failing due to this issue.Issue
AWLS2-396